| *** dcammue has quit (Quit: Quit) | 00:43 | |
| *** bennet has quit (Quit: Connection closed for inactivity) | 03:55 | |
| *** Damon has quit (Quit: Connection closed for inactivity) | 07:33 | |
| *** dcammue has quit (Read error: Connection reset by peer) | 07:49 | |
| *** dcammue has quit (Remote host closed the connection) | 07:50 | |
| *** Amar has quit (Quit: Connection closed for inactivity) | 08:25 | |
| *** anthony_p has quit (Ping timeout: 480 seconds) | 08:26 | |
| *** dcammue has quit (Remote host closed the connection) | 09:24 | |
| dcammue | Good morning arya and devesh | 09:26 |
|---|---|---|
| arya | sorry I was asleeo good morning | 15:45 |
| arya | asleep | 15:45 |
| jelkner | You rock Thomas! | 16:33 |
| jelkner | Great to see you here! | 16:33 |
| jelkner | Are you here thomasboimah? | 16:34 |
| thomasboimah | Yes | 16:34 |
| jelkner | Super. | 16:34 |
| thomasboimah | I am also in the novawebdev | 16:34 |
| jgurara | Hello guys | 16:34 |
| thomasboimah | Hello jgurara | 16:34 |
| jelkner | Yeah, since we are meeting with you, not zOnny, let's meet here. | 16:34 |
| jelkner | Your call. | 16:34 |
| thomasboimah | sure | 16:35 |
| thomasboimah | That's fine with me | 16:35 |
| jelkner | We're all here now, so let's meet here. | 16:35 |
| jelkner | Our "big goal" is to integrate jgurara and Karaaaaa (and Ben, but he's not here this week) into our development team | 16:35 |
| jelkner | Just like zOnny it mentoring you, thomasboimah, we agreed you would mentor them, right? | 16:36 |
| thomasboimah | I will be glad to do that | 16:36 |
| jelkner | sweet | 16:36 |
| jelkner | So, let me share what we talked about on Tuesday | 16:38 |
| jelkner | and then i'll let you figure things out with them | 16:39 |
| jelkner | I asked Karaaaaa and jgurara what they were working on. | 16:39 |
| jelkner | They both told me they were writing their own Todo apps | 16:39 |
| jelkner | that made a lot of sense to me, since that is the default app in the official Django documentation these days I think | 16:40 |
| jelkner | (it used to be a blog) | 16:40 |
| jelkner | so, I suggested the following plan pending your approval thomasboimah: | 16:40 |
| jelkner | 1. They get their own ToDo apps to the point where they think they are ready to show to others. | 16:40 |
| jelkner | 2. You do a "show and tell" session where each of them shares their working version. | 16:41 |
| jelkner | 3. You discuss how they should now join forces with you, thomasboimah, on the ToDo app we are writing for our own use | 16:41 |
| jelkner | Doe that make sense? | 16:41 |
| thomasboimah | Nice! | 16:41 |
| jelkner | LOL, i keep telling them i was expecting a +1 | 16:42 |
| jelkner | cool, i'll leave the 3 of you to chat then. | 16:42 |
| thomasboimah | That is a great planning. We learning django by doing | 16:42 |
| thomasboimah | jelkner, and Karaaaaa can you guys please give me access to your todo's? | 16:43 |
| Karaaaaa | yeah | 16:43 |
| thomasboimah | jgurara, | 16:43 |
| thomasboimah | NOT jelkner | 16:43 |
| jgurara | Okay | 16:43 |
| Karaaaaa | https://codeberg.org/Karaaaaa/To-Do-App | 16:44 |
| Karaaaaa | sorry ill add you one moment | 16:44 |
| thomasboimah | tboimah is my username | 16:44 |
| Karaaaaa | i added you | 16:46 |
| jgurara | just added you | 16:46 |
| jgurara | i will paste the link | 16:46 |
| jgurara | https://codeberg.org/gar821/django_stuff/src/branch/main/todoproject | 16:46 |
| thomasboimah | Nice | 16:47 |
| Karaaaaa | when would we want to meet to share our projects? | 16:47 |
| thomasboimah | Thanks I am going to review that now | 16:47 |
| thomasboimah | I will be checking you guys repo everyday for changes to give feedback. Dose that sound good you? | 16:48 |
| Karaaaaa | yeah! | 16:48 |
| jgurara | Yeah | 16:48 |
| thomasboimah | Okay i am going to review Karaaaaa and jgurara code now. What file do you want me to start? ex. models.py, views.py, urls.py ect | 16:52 |
| thomasboimah | *Okay i am going to review Karaaaaa and jgurara code now. What file do you want me to start with? ex. models.py, views.py, urls.py etc | 16:53 |
| Karaaaaa | maybe views.py | 16:53 |
| thomasboimah | Nice! before that do you guys want to ask me any question Karaaaaa and jgurara ? | 16:55 |
| Karaaaaa | I can't think of any right now | 16:55 |
| jgurara | I have no questions | 16:55 |
| thomasboimah | nice Karaaaaa i just view your file structure and it is great that you are making commit day by day. But i also have some question and suggestion concerning your file structure before i can move on reviewing your views.py | 17:02 |
| Karaaaaa | yeah i really need to consolidate it | 17:02 |
| thomasboimah | I noticed you created multiple apps (createaccount, login, todo, todos). This is very common when we start learning Django, but it’s a good moment to talk about Django structure. | 17:05 |
| Karaaaaa | yeah | 17:06 |
| thomasboimah | jgurara, can i be done with karaaa before we more on to you? I see that you structure you work good | 17:09 |
| thomasboimah | *your* | 17:09 |
| jgurara | Sure | 17:09 |
| thomasboimah | nice! | 17:09 |
| thomasboimah | okay back to Karaaaaa | 17:10 |
| thomasboimah | In Django, an app usually represents a responsibility, not a single feature or page. For example | 17:11 |
| thomasboimah | Auth-related things (login, logout, signup) usually live in one accounts app | 17:12 |
| Karaaaaa | ok, so like different sections of related things? so should i put the rest of my todo stuff in one app? | 17:13 |
| thomasboimah | ToDo functionality should live in one app (todo or todos, not both) | 17:13 |
| Karaaaaa | ok | 17:13 |
| thomasboimah | Yes Karaaaaa Auth related things you should put it in one app like "accounts" and Todo functionality in one app like todo. | 17:14 |
| Karaaaaa | alright | 17:14 |
| thomasboimah | you should choose between the todos and todo | 17:15 |
| Karaaaaa | I'll just stick with todo | 17:15 |
| thomasboimah | Nice! is there any question? | 17:15 |
| thomasboimah | Or anything you don't understand Karaaaaa | 17:16 |
| Karaaaaa | No it makes a lot more sense now | 17:16 |
| thomasboimah | sweet | 17:16 |
| thomasboimah | now i will move on to view jgurara code. Karaaaaa you want me to view you code too or you want to fix the file structure issue first? | 17:17 |
| Karaaaaa | ill fix the file structure first so its easier for you | 17:18 |
| Karaaaaa | ill finish that today | 17:18 |
| thomasboimah | Great | 17:18 |
| Karaaaaa | thanks | 17:18 |
| thomasboimah | You are hardly welcome | 17:20 |
| thomasboimah | jgurara, I reviewed your views.py, and overall it is really solid work. Your use of class-based views, LoginRequiredMixin, user-scoped querysets, and the search logic with Q all show good understanding of Django | 17:25 |
| jgurara | thanks | 17:25 |
| thomasboimah | But There is a few improvements I want us to make, mainly around security and consistency | 17:26 |
| jgurara | Ok | 17:26 |
| thomasboimah | You can see that as you stories | 17:26 |
| thomasboimah | You can see that as user stories | 17:26 |
| thomasboimah | 1. Don't you think it will be great if you restrict access so users can only update or delete their own tasks, not just any task by ID. (TaskUpdateView and TaskDeleteView ) | 17:29 |
| jgurara | yeah | 17:29 |
| thomasboimah | I noticed you’re mixing FBVs and CBVs. That’s okay, but for consistency, it’s good to reflect on why you chose an FBV here (mark_complete) and whether a CBV make sense there too. | 17:36 |
| jgurara | okay | 17:36 |
| thomasboimah | I hope you understanding that mean of FBVs and CBVs | 17:38 |
| jgurara | Function based views, Class based views | 17:38 |
| thomasboimah | Great! | 17:38 |
| thomasboimah | you rock jgurara | 17:38 |
| jgurara | thanks for the advice | 17:39 |
| thomasboimah | You are hardly welcome jgurara | 17:40 |
| thomasboimah | is there any questions? | 17:40 |
| jgurara | None from me | 17:42 |
| thomasboimah | For now jgurara , focus on adding the access restriction and thinking about the FBV/CBV choice. then we can complete the review for the views.py tomorrow then we can move on | 17:43 |
| thomasboimah | Is that make sense to you? | 17:43 |
| jgurara | Yes | 17:43 |
| thomasboimah | Great i am going to make sure to clone you and Karaaaaa repo to my machine and run it | 17:44 |
| jgurara | ok | 17:45 |
| thomasboimah | Just take me as the user for you guys app or customer. so I will be bring in user stories or request for new feature | 17:45 |
| Karaaaaa | alright | 17:46 |
| thomasboimah | Are you guys okay with that? | 17:46 |
| jgurara | Yes | 17:46 |
| Karaaaaa | yes | 17:46 |
| thomasboimah | Nice | 17:46 |
| thomasboimah | I will still be have until your class over you can ask my any question you want | 17:47 |
| thomasboimah | I will still be here until your class over you can ask my any question you want | 17:47 |
| thomasboimah | *me* | 17:47 |
| thomasboimah | lol tepo error | 17:47 |
| Karaaaaa | sounds good, we have about 7 minutes | 17:48 |
| thomasboimah | lol typo error | 17:48 |
| thomasboimah | Will you guys be here tomorrow? | 17:48 |
| Karaaaaa | we have this class every other day not on weekends so no unfortunately | 17:49 |
| jgurara | We will be here on Monday | 17:49 |
| Karaaaaa | but i can talk over the weekend probably | 17:49 |
| thomasboimah | Okay | 17:49 |
| jgurara | i cant | 17:49 |
| *** arya has quit (Quit: Connection closed for inactivity) | 17:53 | |
| Karaaaaa | by thomasboimah have a good weekend if i dont come by | 17:54 |
| jgurara | Class is ending, see you next Monday, Thomas | 17:54 |
| thomasboimah | Okay you too | 17:54 |
| *** Karaaaaa has quit (Quit: Leaving) | 17:54 | |
| *** jgurara has quit (Quit: Leaving) | 17:54 | |
| *** thomasboimah has quit (Remote host closed the connection) | 18:01 | |
| *** jelkner has quit (Remote host closed the connection) | 18:13 | |
| *** dcammue has quit (Ping timeout: 480 seconds) | 18:58 | |
| *** BigBrother has joined #jetrowebdev | 21:17 | |
| *** thomasboimah has quit (Remote host closed the connection) | 22:08 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!